RFR (S): 8012102: CollectedHeap::ensure_parsability is not always called during heap inspection

[Erik Helin]

On 04/15/2013 10:30 AM, Mikael Gerdin wrote:
> Erik,
>
> On 2013-04-15 09:01, Erik Helin wrote:
>> Hi all,
>>
>> this change fixes a bad refactoring. The method
>> CollectedHeap::ensure_parsability must always be called prior to doing
>> performing a heap inspection (to be able to traverse TLABs).
>>
>> A previous change refactored the code so that the method was only called
>> if a full GC was requested before the heap inspection.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ehelin/8012102/webrev.00/
>
> This looks good,
> can you please update the comment about calling ensure_parsability to
> mention that the call is also needed even if _full_gc is not set.
> That will make the entire change self-explanatory.

Sure, will do.

On 04/15/2013 10:30 AM, Mikael Gerdin wrote:
> I'm fine with you changing the comment and pushing without sending out a
> new webrev.

Thanks!
Erik

> /Mikael
>
>>
>> Bug:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012102
>>
>> Thanks,
>> Erik
>>