RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

[Karen Kinnear]

Markus,

Looks good.

Minor comments:

1. systemDictionary.cpp
Does the post_class_load_event internal logic want to be #ifdef INCLUDE_TRACE/#endif
so it builds with embedded?

2. tracestream.hpp
  print_val (both)
  - don't you need a ResourceMark rm to use as_C_string() and name_and_sig_as_C_string()?

thanks,
Karen

p.s. guess I didn't track this closely enough - I thought the class load event was already in hs24? 
On Apr 16, 2013, at 5:35 PM, Markus Grönlund wrote:

> Hi again,
>  
> The changeset for this has been updated slightly to reflect underlying changes in hs24.
>  
> Still looking for reviews for this change to add information about class loading and unloading to the event based tracing framework for HS24.
>  
> BugID:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012182
>  
> Webrev (updated):
> http://cr.openjdk.java.net/~mgronlun/8012182/webrev02/
>  
> Thanks in advance
> Markus
>  
>  
>  
>  
> From: Markus Grönlund 
> Sent: den 15 april 2013 10:17
> To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.net
> Subject: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24)
>  
> Greetings,
>  
> Kindly asking for reviews for the change to add class load and unload information to the event based tracing framework to HS24.
>  
> BugID:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012182
>  
> Webrev:
> http://cr.openjdk.java.net/~mgronlun/8012182/webrev01/
>  
> Thanks
> Markus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20130416/26e9963c/attachment.htm>