Why the type of GCId in gcTrace.hpp is uint?

[云达(Yunda)]

Jesper,

Thanks and I'll have a look at it.

Regards,
Yunda


> -----Original Message-----
> From: Jesper Wilhelmsson [mailto:jesper.wilhelmsson at oracle.com]
> Sent: Wednesday, April 17, 2013 7:13 PM
> To: 云达(Yunda)
> Cc: hotspot-gc-dev openjdk.java.net (hotspot-gc-dev at openjdk.java.net);
> serviceability-dev at openjdk.java.net
> Subject: Re: Why the type of GCId in gcTrace.hpp is uint?
>
> 云达,
>
> I have a fix four this in review right now. I send the mail yesterday, feel free to
> have a look at it.
>
> I changed the GC ID and Compiler ID since they are both unsigned int values.
> The Javalangthread is a long so I didn't include that in this change.
> /Jesper
>
>
> 云达(Yunda) skrev 15/3/13 3:36 AM:
> > Jesper,
> >
> > Thanks. I think you should consider that in trace.xml the type of compileID is
> INTEGER and the type of javalangthread is JAVALANGTHREAD. Since they all
> have similar meanings( as an ID), could they be a same type?
> >
> > Regards,
> > Yunda
> >
> >> -----Original Message-----
> >> From: Jesper Wilhelmsson [mailto:jesper.wilhelmsson at oracle.com]
> >> Sent: Thursday, March 14, 2013 11:30 PM
> >> To: 云达(Yunda)
> >> Cc: hotspot-gc-dev openjdk.java.net (hotspot-gc-dev at openjdk.java.net);
> >> serviceability-dev at openjdk.java.net
> >> Subject: Re: Why the type of GCId in gcTrace.hpp is uint?
> >>
> >> Hi Yunda,
> >>
> >> Thanks for reporting this! It is a bug indeed.
> >> I filed CR 8010090 and will fix it asap.
> >>
> >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010090
> >>
> >> Thanks,
> >> /Jesper
> >>
> >>
> >> On 14/3/13 11:59 AM, 云达(Yunda) wrote:
> >>> Hi all,
> >>>
> >>> I notice that in gcTrace.hpp
> >>> <http://hg.openjdk.java.net/hsx/hsx24/hotspot/file/be21f8a4d42c/src/sh
> >>> are/vm/gc_implementation/shared/gcTrace.hpp>
> >>> the type of GCId is unit, but in trace.xml
> >>> <http://hg.openjdk.java.net/hsx/hsx24/hotspot/file/be21f8a4d42c/src/sh
> >>> are/vm/gc_implementation/shared/gcTrace.hpp>
> >>> the type is ULONG. Could someone tell me if there’s a special reason,
> >>> or it’s just a mistake?
> >>>
> >>> Regards,
> >>>
> >>> Yunda
> >>>
> >>>
> >>> ----------------------------------------------------------------------
> >>> ----------
> >>>
> >>> This email (including any attachments) is confidential and may be
> >>> legally privileged. If you received this email in error, please delete
> >>> it immediately and do not copy it or use it for any purpose or
> >>> disclose its contents to any other person. Thank you.
> >>>
> >>> 本电邮(包括任何附件)可能含有机密资料并受法律保护。如您不是正确
> 的
> >> 收件人，请您立即
> >>> 删除本邮件。请不要将本电邮进行复制并用作任何其他用途、或透露
> 本
> >> 邮件之内容。谢谢。
> >
> > ________________________________
> >
> > This email (including any attachments) is confidential and may be legally
> privileged. If you received this email in error, please delete it immediately and
> do not copy it or use it for any purpose or disclose its contents to any other
> person. Thank you.
>
> >
> > 本电邮(包括任何附件)可能含有机密资料并受法律保护。如您不是正确的
> 收件人，请您立即删除本邮件。请不要将本电邮进行复制并用作任何其他
> 用途、或透露本邮件之内容。谢谢。
> >

________________________________

This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you.

本电邮(包括任何附件)可能含有机密资料并受法律保护。如您不是正确的收件人，请您立即删除本邮件。请不要将本电邮进行复制并用作任何其他用途、或透露本邮件之内容。谢谢。