Request for review - 8013184 CMS: Call reset_after_compaction() only if a compaction has been done

[Kirk Pepperdine]

Hi Jon,

I think you're right in the common misconception is that CMS does a full GC. However I like to make the distinction in that Full GC's work in all memory pools where as partial collections don't. Thus CMS is not a Full GC. I've been working hard in the field to make this distinction and it would be nice if the code read this way also.

Regards,
Kirk

> Would you say that CMS does anything other than a full GC?   At least in
> the general sense of "full GC".  I qualify that because CMS usually
> only does a collection of the tenured generation but it's often
> referred to as a "full GC".   If you also think of a CMS collection
> as a full GC, then I think the "full_gc" in "full_gc_did_compaction"
> is implied.  If you don't think that CMS usually does a full GC and
> only the compacting GC is a full GC, then "_did_compact" implies
> a full GC because that's the only time a compaction is done.
> 
> So I'm not keen on changing the name to "_full_gc_did_compact"
> because it sounds redundant.  But l'll do it if you think it is
> more clear.
> 
> Thanks.
> 
> Jon
> 
> 
>> 
>> /Mikael
>