Request for review: 8006628: NEED_TEST for JDK-8002870

[John Cuthbertson]

Hi Filipp,

I can sponsor the change for you. Just point me to your workspace.

JohnC

On 2/8/2013 4:41 AM, Filipp Zhinkin wrote:
> Well, I've got two reviews now.
>
> As I understand, now I need to find a sponsor for this change? I'll be 
> very grateful if anyone could do it.
>
> Thanks,
> Filipp.
>
> On 02/08/2013 12:05 PM, Filipp Zhinkin wrote:
>> Mikael,
>>
>> thanks for review!
>>
>> Filipp.
>>
>> On 02/07/2013 11:26 PM, Mikael Gerdin wrote:
>>> Filipp
>>>
>>> On 2013-02-07 16:31, Filipp Zhinkin wrote:
>>>> I need one more review for this test, so if someone could, please 
>>>> review
>>>> it.
>>>
>>> It looks good. Ship it!
>>>
>>> /Mikael
>>>
>>>>
>>>> Thanks,
>>>> Filipp.
>>>>
>>>> On 01/30/2013 03:21 PM, Filipp Zhinkin wrote:
>>>>> Here is an updated webrev:
>>>>> http://cr.openjdk.java.net/~kshefov/8000311/webrev.01/
>>>>>
>>>>> I've added ExplicitGCInvokesConcurrent option and replaced
>>>>> heap-filling by frequent System.gc() calls.
>>>>>
>>>>> Thanks,
>>>>> Filipp.
>>>>>
>>>>> On 01/29/2013 01:15 PM, Filipp Zhinkin wrote:
>>>>>> Hi John,
>>>>>>
>>>>>> thanks for advice! I'll reimplement the test using System.gc() calls
>>>>>> and -XX:+ExplicitGCInvokesConcurrent option.
>>>>>> And yes, you're right, PLAB resizes only at the end of incremental
>>>>>> GC. Thats why I've tried to provoke GC by filling up the heap 
>>>>>> instead
>>>>>> of calling System.gc() (I've missed ExplicitGCInvokesConcurrent flag
>>>>>> before).
>>>>>>
>>>>>> Thanks,
>>>>>> Filipp.
>>>>>>
>>>>>> On 01/28/2013 10:58 PM, John Cuthbertson wrote:
>>>>>>> Hi Filipp,
>>>>>>>
>>>>>>> In addition to what Jon suggests (i.e. using System.gc() to
>>>>>>> guarantee a GC), please add -XX:+ExplicitGCInvokesConcurrent. The
>>>>>>> addition of this flag will cause G1 to perform an incremental GC
>>>>>>> (instead of the full GC that a System.gc() call provokes). IIRC the
>>>>>>> PLAB resizing code is only exercised at the end of an 
>>>>>>> incremental GC.
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> JohnC
>>>>>>>
>>>>>>> On 1/28/2013 9:18 AM, Jon Masamitsu wrote:
>>>>>>>> Can this test be implemented using a call to
>>>>>>>> System.gc() instead of trying to fill up the heap
>>>>>>>> to provoke a GC?
>>>>>>>>
>>>>>>>> Jon
>>>>>>>>
>>>>>>>> On 01/21/13 03:14, Filipp Zhinkin wrote:
>>>>>>>>> Hi all,
>>>>>>>>>
>>>>>>>>> Would someone review the following regression test please?
>>>>>>>>>
>>>>>>>>> Test verifies that VM will not crash with G1 GC and
>>>>>>>>> ParallelGCThreads == 0.
>>>>>>>>>
>>>>>>>>> To ensure that it is true test allocates array until OOME.
>>>>>>>>> Max heap size is limited by 32M for this test to ensure that GC
>>>>>>>>> will occur.
>>>>>>>>> Since crash could occur only during PLAB resizing after GC,
>>>>>>>>> ResizePLAB option is explicitly turned on.
>>>>>>>>>
>>>>>>>>> http://cr.openjdk.java.net/~kshefov/8000311/webrev.00/
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Filipp.
>>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>