RFR (S): 8008737: The trace event vm/gc/heap/summary is missing for CMS

[Bengt Rutisson]

Hi Erik,

I think this looks good.

One question:

CMSCollector::register_gc_start() is currently called like this:

register_gc_start(GenCollectedHeap::heap()->gc_cause());

With your patch you look up the heap inside 
CMSCollector::register_gc_start() to call trace_heap_before_gc() on it. 
What do you think about passing the heap to 
CMSCollector::register_gc_start() instead of passing the cause?

Thanks,
Bengt



On 2/24/13 10:40 AM, Erik Helin wrote:
> Hi all,
>
> this change adds the trace event vm/gc/heap/summary to the CMS collector.
>
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8008737/webrev.00/
>
> Bug:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008737
>
> Testing:
> JPRT
>
> Thanks,
> Erik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20130225/7be7f5ef/attachment.htm>