Request for review (vs) - 8014546: MetaspaceAux print_metaspace_change() should print "used" after GC not capacity

Jon Masamitsu jon.masamitsu at oracle.com
Thu Jun 6 00:23:54 UTC 2013


Thanks.

On 6/5/2013 3:00 PM, John Cuthbertson wrote:
> Hi Jon,
>
> Code changes look good.
>
> JohnC
>
> On 6/5/2013 1:18 PM, Jon Masamitsu wrote:
>> As the summary says, print the used metaspace in 
>> print_metaspace_change() instead
>> of capacity.  The output used to be
>>
>> previous_used  ->  capacity  (reserved)
>>
>> and now is
>>
>> previous_used -> used_after_GC  (reserved)
>>
>> This makes the print_metaspace_change() more similar to the
>> GC print_heap_change().
>>
>> http://cr.openjdk.java.net/~jmasa/8014546/webrev.00/
>>
>> Two lines changed.
>>
>> --- a/src/share/vm/memory/metaspace.cpp
>> +++ b/src/share/vm/memory/metaspace.cpp
>> @@ -2603,14 +2603,14 @@
>>                          "->" SIZE_FORMAT
>>                          "("  SIZE_FORMAT ")",
>>                          prev_metadata_used,
>> -                        allocated_capacity_bytes(),
>> +                        allocated_used_bytes(),
>>                          reserved_in_bytes());
>>    } else {
>>      gclog_or_tty->print(" "  SIZE_FORMAT "K"
>>                          "->" SIZE_FORMAT "K"
>>                          "("  SIZE_FORMAT "K)",
>>                          prev_metadata_used / K,
>> -                        allocated_capacity_bytes() / K,
>> +                        allocated_used_bytes() / K,
>>                          reserved_in_bytes()/ K);
>>    }
>>
>> Thanks.
>>
>> Jon
>




More information about the hotspot-gc-dev mailing list