RFR (XS): 8015903: Fomat issue with -XX:+PRINTADAPTIVESIZEPOLICY on JDK8

[John Cuthbertson]

Hi Jesper,

The change is psAdaptiveSizePolicy.cpp looks good.

I don't, however, think you should remove the line break in 
psScavenge.cpp. I _that_ that line break is meant to be there. The 
output beginning with "avg_survived_padded_avg" is slightly indented. 
Compare the other places where "AdaptiveSizeStart" is printed in 
psMarkSweep.cpp and psParallelCompact.cpp. Leaving line break in will 
make the output:

AdaptiveSizeStart: 23.548 collection: 67
    avg_survived_padded_avg: 728176.250000  avg_promoted_padded_avg: 
223962144.000000  avg_pretenured_padded_avg: 187235776.000000 
tenuring_thresh: 14  target_size: 1048576

JohnC

On 6/5/2013 2:50 PM, Jesper Wilhelmsson wrote:
> Hi,
>
> Can I have a couple of reviews for this really minor fix?
>
> 8015903: Fomat issue with -XX:+PRINTADAPTIVESIZEPOLICY on JDK8
>
> A missing line break in the adaptive size verbose logging has been added.
>
> When looking at this I also found that an existing line break caused a 
> slightly ugly verbose output when breaking a line causing a second 
> line without a identifier at the beginning. I removed that line break 
> as well in this change.
>
>
> webrev:
> http://cr.openjdk.java.net/~jwilhelm/8015903/hotspot-webrev/
>
>
>
> Output before:
>
> AdaptiveSizePolicy::update_averages:  survived: 163840  promoted: 0  
> overflow: falseAdaptiveSizeStart: 23.548 collection: 67
>    avg_survived_padded_avg: 728176.250000 avg_promoted_padded_avg: 
> 223962144.000000 avg_pretenured_padded_avg: 187235776.000000  
> tenuring_thresh: 14 target_size: 1048576
>
>
> Output after:
>
> AdaptiveSizePolicy::update_averages:  survived: 163840  promoted: 0  
> overflow: false
> AdaptiveSizeStart: 23.548 collection: 67 avg_survived_padded_avg: 
> 728176.250000  avg_promoted_padded_avg: 223962144.000000 
> avg_pretenured_padded_avg: 187235776.000000 tenuring_thresh: 14  
> target_size: 1048576
>
>
> Thanks,
> /Jesper