RFR(M/L): 7145569: G1: optimize nmethods scanning

Thomas Schatzl thomas.schatzl at oracle.com
Fri Jun 14 11:05:03 UTC 2013


  some minor comment:

On Fri, 2013-06-14 at 12:15 +0200, Thomas Schatzl wrote:
> Hi John,
>   I had some initial look at the code, first comments (mostly about
> typos, comments) below:
> On Thu, 2013-06-13 at 15:30 -0700, John Cuthbertson wrote:
> heapRegion.hpp
> - push_strong_code_root vs. add_strong_code_root

Forgot to improve the comment, happens when I do not immediately write
down the full comment...

This is about the names of for pairing insertion/deletion operations for
the data type. Imo push does not go well with remove, I would prefer the
common use of add/remove instead of push/remove.

While "push" also adds to the collection, push is commonly used for
stack operation, and imo implies some stack like behavior. I cannot find
any reason for that in case of remembered sets or an nmethod collection.

All imo, and minor.


More information about the hotspot-gc-dev mailing list