RFR (S): 8014240 G1: Add remembered set size information to output of G1PrintRegionLivenessInfo

John Cuthbertson john.cuthbertson at oracle.com
Wed May 15 23:30:27 UTC 2013


Hi Thomas,

Looks good. Ship it.

JohnC

On 5/15/2013 7:51 AM, Thomas Schatzl wrote:
> Hi,
>
>    thanks for the review!
>
> On Tue, 2013-05-14 at 16:03 -0700, John Cuthbertson wrote:
>> Hi Thomas,
>>
>> The changes look good.
>>
>> In the test would it make more sense to make RunAndWaitForMarking
>> perform a system GC and execute it with +ExplicitGCInvokesConcurrent?
> That's a good idea. I've changed the test accordingly. A new webrev can
> be found at http://cr.openjdk.java.net/~tschatzl/8014240/webrev.1/ .
>
> Tested the change using jprt and jtreg.
>
> Thanks,
> Thomas
>
>




More information about the hotspot-gc-dev mailing list