RFR (XXS): 8014765: VM exits if MaxTenuringThreshold is set below the default InitialTenuringThreshold, and InitialTenuringThreshold is not set

Bengt Rutisson bengt.rutisson at oracle.com
Thu May 16 21:42:26 UTC 2013


Hi Thomas,

The change will work and the test looks good.

However, it seems a bit odd to have this default value and flag setting 
in check_vm_args_consistency(). Could we move it up 
Arguments::finalize_vm_init_args()? That method already has similar code 
for OptoLoopAlignment and MaxLoopPad flags.

Bengt

On 5/16/13 11:21 PM, Thomas Schatzl wrote:
> Hi all,
>
>    could I get a quick review of the following CR?
>
> The VM exits if MaxTenuringThreshold is set below the default
> InitialTenuringThreshold, and InitialTenuringThreshold is not set.
>
> Checking of InitialTenuringThreshold <= MaxTenuringThreshold has only
> been introduced with 6843347.
>
> This change automatically adapts InitialTenuringThreshold if it has the
> default value and is > MaxTenuringThreshold to MaxTenuringThreshold.
>
> bugs.sun.com
> http://bugs.sun.com/view_bug.do?bug_id=8014765
>
> jira:
> https://jbs.oracle.com/bugs/browse/JDK-8014765
>
> webrev:
> http://cr.openjdk.java.net/~tschatzl/8014765/webrev/
>
> Testing:
> jtreg test case
>
> Thomas
>




More information about the hotspot-gc-dev mailing list