RFR (S): 8067469: G1 ignores AlwaysPreTouch

Thomas Schatzl thomas.schatzl at oracle.com
Tue Dec 16 18:35:24 UTC 2014


Hi Mikael,

On Tue, 2014-12-16 at 13:52 +0100, Mikael Gerdin wrote:
> Hi Thomas,
> 
> On 2014-12-16 13:23, Thomas Schatzl wrote:
> > Hi all,
> >
> >    can I have reviews for the following small change?
> >
> > It adds pre-touching of allocated memory in G1, which has been forgotten
> > to be implemented when changing this code in JDK-8038423.
> >
> > This change adds this and refactors the pre-touch code to a single
> > method in the os class.
> >
> > CC'ed runtime since it changes code in os.hpp/cpp.
> >
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8067469
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8067469/webrev/
> 
> Change looks good to me.

  Thanks for the review.

Thomas





More information about the hotspot-gc-dev mailing list