RFR(S): 8035822 - Unable to test minimalVM
Stefan Karlsson
stefan.karlsson at oracle.com
Wed Feb 26 22:32:15 UTC 2014
On 2014-02-26 23:08, Jesper Wilhelmsson wrote:
> Hi again,
>
> There have been a lot of new unit tests added in jdk9 so this change
> did not apply cleanly to jdk8. Therefore I'm obliged to ask for a
> second round of reviews to backport this trivial change. Sorry for the
> inconvenience.
>
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8035822/webrev.jdk8u/
You moved the call into INCLUDE_VM_STRUCTS instead of INCLUDE_ALL_GCS:
- run_unit_test(TestOldFreeSpaceCalculation_test());
#if INCLUDE_VM_STRUCTS
+ run_unit_test(TestOldFreeSpaceCalculation_test());
run_unit_test(VMStructs::test());
#endif
StefanK
>
> Thanks,
> /Jesper
>
>
> Jesper Wilhelmsson skrev 26/2/14 12:31:
>> Hi,
>>
>> Could I have a few reviews of this small change?
>>
>> A few lines of unit test code ended up on the wrong side of an #ifdef
>> INCLUDE_ALL_GCS leading to errors when running the minimal VM.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8035822
>>
>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8035822/webrev/
>>
>> Thanks,
>> /Jesper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20140226/1e09fc22/attachment.htm>
More information about the hotspot-gc-dev
mailing list