[RFR] 8064716: TestHumongousShrinkHeap.java can not be run with -XX:+ExplicitGCInvokesConcurrent

[Thomas Schatzl]

Hi,

On Fri, 2014-11-14 at 09:46 +0100, Bengt Rutisson wrote:
> On 2014-11-13 19:17, Jesper Wilhelmsson wrote:
> > That depends.. Will this work for all cases where 
> > -XX:+ExplicitGCInvokesConcurrent is added to the command line from 
> > different frameworks etc?
> 
> Jesper, the command line flags specified in the @run tag are *appened* 
> to whatever the framework passes in. So, with Andrey's change the 
> -XX:-ExplicitGCInvokesConcurrent in the @run tag will always override 
> any -XX:+ExplicitGCInvokesConcurrent passed in from the framework. Note 
> that this is a "normal" hotspot flag (not specially treated like the GC 
> selection flags) so there is not conflict in specifying the same flag 
> multiple times on the command line. The rule "last one wins" applies.
> 
> Andrey, the changes look good.
> 
> One minor thing is that I would prefer the @run tag in 
> TestHumongousShrinkHeap.java to be a single line. I think it is a bit 
> hard to read when the @run tag gets split up over multiple lines:

I agree with Bengt, and would also prefer if the @run tag contents were
not split into multiple lines.

Thanks,
  Thomas