review request (S): 8057531: refactor gc arg processing code slightly

John Coomes John.Coomes at oracle.com
Thu Sep 4 23:13:20 UTC 2014


Jon Masamitsu (jon.masamitsu at oracle.com) wrote:
> Changes look good.

Thank you!

> If you haven't, could you run your change with
> 
> -XX:+NeverActAsServerClassMachine -XX:+PrintGCDetails -version
> 
> and verify that the serial-gc is selected.

I have a script that runs with all the collectors (plus no collector
specified).  I added NeverActAsServerClassMachine and the results were
the same as an unmodified vm.

-John

> Reviewed.
> 
> Jon
> 
> 
> On 09/04/2014 02:30 AM, John Coomes wrote:
> > Please review this small refactoring of gc argument processing code:
> >
> > http://cr.openjdk.java.net/~jcoomes/8u/8u40/8057531-refactor-gc-arg-proc/
> >
> > Thanks for any feedback.
> >
> > -John
> 



More information about the hotspot-gc-dev mailing list