review request (S) - 8057824 methods to copy allocation context stats

John Coomes John.Coomes at oracle.com
Tue Sep 9 17:53:25 UTC 2014


Mikael Gerdin (mikael.gerdin at oracle.com) wrote:
> Hi John,
> 
> On Tuesday 09 September 2014 00.21.51 John Coomes wrote:
> > Hi,
> > 
> > Please review this interface for copying allocation context statistics
> > to native or java arrays.
> > 
> > http://cr.openjdk.java.net/~jcoomes/8u/8u40/8057824-stats-copy/
> 
> Why do you add the additional entry point to the CollectedHeap superclass?
> All the other related code seems to be specific to G1.
> If we ever decide to extend this sort of functionality to to the other 
> collectors it's a simple change to do when we actually need it.

There is another project that is likely to use this with the serial
collector, so this is a bit of future-proofing.  If I confirm that
they intend to use it, are you okay with the change?

-John



More information about the hotspot-gc-dev mailing list