review request (S/M) - 8057827: notify an obj when stats are available

John Coomes John.Coomes at oracle.com
Wed Sep 10 12:59:38 UTC 2014


Jon Masamitsu (jon.masamitsu at oracle.com) wrote:
> 
> On 09/09/2014 01:09 PM, John Coomes wrote:
> > Mikael Gerdin (mikael.gerdin at oracle.com) wrote:
> >> On Tuesday 09 September 2014 00.45.04 John Coomes wrote:
> >>> Please review the api for notifying an object when updated statistics
> >>> are available at the end of a gc pause:
> >>>
> >>> 8057827: notify an obj when allocation context stats are available
> >>>
> >>> http://cr.openjdk.java.net/~jcoomes/8u/8u40/8057827-stats-notify/
> >> Can you maintain this object as a global JNI handle (jobject) inside
> >> AllocationContextService instead of adding a new static oop in Universe?
> >>
> >> The other static oops in Universe seem to be more system and bootstrap-related
> >> as opposed to the user-settable nature of the notification object.
> > Thanks again for looking.
> >
> > FWIW, the expected usage is that it will be set soon after
> > initialization (from libraries code), and remain in place for the
> > remainder of the JVM's lifetime, so it's mostly static.
> >
> > I'll look at using a global jni handle instead, but I'd like to do
> > that as a separate change.
> >
> > -John
> 
> John,
> 
> Assuming the change to _available that Mikael suggested,
> rest looks good.

Sure, I already adopted that suggestion.  Thanks for reviewing it.

-John



More information about the hotspot-gc-dev mailing list