Introduce "region type" field to G1 HeapRegions

[Tony Printezis]

Thomas and Bengt,

Inline.

On 9/15/14, 7:39 AM, Bengt Rutisson wrote:
>
> Hi,
>
> On 2014-09-15 11:37, Thomas Schatzl wrote:
>> Hi,
>>
>> On Fri, 2014-09-12 at 22:45 -0400, Tony Printezis wrote:
>>> Hi Bengt, Thanks for looking at it. Please see inline.
>>>
>>> On 9/12/14, 8:20 AM, Bengt Rutisson wrote:
>>>> Hi Tony,
>>>>
>>>> Nice cleanup! I like it!
>>>>
>> I agree with Bengt here.
>>
>> [...]
>>> The new webrev is here:
>>>
>>> http://cr.openjdk.java.net/~tonyp/g1-region-type/webrev.2/
>>>
>>> And these are the diffs over the previous one:
>>>
>>> http://cr.openjdk.java.net/~tonyp/g1-region-type/webrev.2.diff/
>>>
>>> Thanks again. BTW, I don't know your current policy: Is this a change
>>> you'll be interested in back-porting to JDK 8?
>>>
>>> Tony
>> Looks good. Two last minor things I have:
>>
>> - in g1HotCardCache.cpp the include to heapRegion.hpp is not required
>> any more.
>>
>> I think Bengt could simply fix that before pushing.
>
> Nice find. I fixed that and pushed the patch. Here's the changeset:
>
> http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/rev/13c5569c0fc4

Thanks for fixing it and for pushing the patch!

>>
>> - the order of words in the humongous region types is not used
>> consistently: the tag values are called HumStarts/Cont, but the methods
>> set/is_continues_humongous().
>> I.e. the position of the type of humongous region changes within the
>> method name which seems without reason.
>>
>> It's not a big issue. If needed, this may as well be fixed in the
>> isHumongous()/continuesHumongous() method naming cleanup.
>
> Yes, I agree that it is better to do this rename together with the 
> isHumongous()/continuesHumongous() method naming cleanup. Especially 
> since I now pushed the rest of the patch ;)

Sounds good. I have the renaming already ready. I'll send out a webrev 
shortly.

Tony

> Thanks,
> Bengt
>
>>
>> Thanks,
>>   Thomas
>>
>>
>

-- 
Tony Printezis | JVM/GC Engineer / VM Team | Twitter

@TonyPrintezis
tprintezis at twitter.com