CRR (S): 8058495: G1: normalize names for isHumongous() and friends.

Bengt Rutisson bengt.rutisson at oracle.com
Tue Sep 16 12:26:00 UTC 2014


Hi Tony,

On 2014-09-15 19:52, Tony Printezis wrote:
> Hi all,
>
> This is a follow-up to JDK-8057768, proposed by Thomas. It normalizes 
> some of the humongous-related method names (and enums). The changes are:
>
> HeapRegion::isHumongous() -> is_humongous()
> HeapRegion::startsHumongous() -> is_starts_humongous()
> HeapRegion::continuesHumongous() -> is_continues_humongous()
>
> HeapRegion::set_startsHumongous() -> set_starts_humongous()
> HeapRegion::set_continuesHumongous() -> set_continues_humongous()
>
> HeapRegionType::HumMask -> HumongousMask
> HeapRegionType::HumStartsTag -> StartsHumongousTag
> HeapRegionType::HumContTag -> ContinuesHumongousTag
>
> G1CollectedHeap::isHumongous() -> is_humongous()
>
> Webrev is here:
>
> http://cr.openjdk.java.net/~tonyp/8058495/webrev.0/

Looks good.

>
> Could I get a couple of reviews please (and a sponsor!!!)? :-)

I can sponsor this. In order to avoid some merge conflicts I may wait a 
couple of days before I push. But I'll handle it soon.

Thanks,
Bengt


>
> Thanks,
>
> Tony
>




More information about the hotspot-gc-dev mailing list