RFR (XS): JDK-8027450 : Improve time reporting in G1 remark

[Stefan Karlsson]

On 2014-09-22 15:53, Thomas Schatzl wrote:
> Hi,
>
> On Mon, 2014-09-22 at 15:31 +0200, Stefan Karlsson wrote:
>> On 2014-09-22 11:06, Thomas Schatzl wrote:
>>> Hi,
>>>
>>> On Fri, 2014-09-19 at 11:25 -0400, Joseph Provino wrote:
>>>> Hi all,
>>>>
>>>> Can I have reviews for the following small change that logs more G1
>>>> Concurrent Mark
>>>> Trace Times.  I also changed G1RemarkGCTraceTime() to G1CMTraceTime()
>>>> because it's
>>>> used in places other than remark.
>>>>
>>>> CR: https://bugs.openjdk.java.net/browse/JDK-8027450
>>>>
>>>> Webrev:http://cr.openjdk.java.net/~jprovino/8027450/webrev.00/
>>>>
>>>> Testing: jprt
>>>>
>>>> I also need a sponsor to commit the changes.
>>> Looks good. Maybe the strings could be changed to fit the existing
>>> though, e.g. "GC ref-proc" -> "Reference processing", and "GC
>>> aggregate-data" -> "Aggregate data".
>> That might be worth doing, but not as a part of this cleanup. Changing
>> the log output is usually a much greater undertaking than this small
>> cleanup.
>>
> Fine with me.

Since aggregate-data is a new string, I think it's good if we give it a 
good name from the start. I'm just opposing trying to change "GC 
ref-proc" in this change.

thanks,
StefanK

>
> Thanks,
>    Thomas
>
>