RFR: 8058298: Separate heap region iterator claim values from the data structures iterated over

Thomas Schatzl thomas.schatzl at oracle.com
Thu Sep 25 11:08:14 UTC 2014


Hi Marcus,

On Fri, 2014-09-19 at 13:13 +0200, Marcus Larsson wrote:
> Hi Thomas, thanks for reviewing!
> 
[...]
>New webrev:
> http://cr.openjdk.java.net/~brutisso/webrev-8058298v2/
> 
> Changes from previous webrev:
> http://cr.openjdk.java.net/~brutisso/webrev-8058298v1-v2/
> 

  thanks for the changes, look good.

One final request :) Is it possible to make the HRClaimer of
G1ParRemoveSelfForwardPtrsTask a member of the task like it is done for
all the other tasks? Then we would also get rid of the parameterless
constructor for HeapRegionClaimer.

I saw that you are also working on "JDK-6979279: remove special-case
code for ParallelGCThreads==0". With that change,
G1CollectedHeap::use_parallel_gc_threads() would be always true,
allowing to make HeapRegionClaimer::initialize() private.

Thanks,
  Thomas





More information about the hotspot-gc-dev mailing list