RFR (M) 8075210: Refactor strong root processing in order to allow G1 to evolve separately from GenCollectedHeap

[Mikael Gerdin]

On 2015-03-18 14:11, Thomas Schatzl wrote:
> Hi,
>
> On Wed, 2015-03-18 at 13:59 +0100, Mikael Gerdin wrote:
>> Hi Thomas,
>>
>> On 2015-03-18 13:32, Thomas Schatzl wrote:
>>> Hi again,
>>>
>>> On Wed, 2015-03-18 at 13:28 +0100, Thomas Schatzl wrote:
>>>> Hi Mikael,
>>>>
>>>> On Tue, 2015-03-17 at 17:00 +0100, Mikael Gerdin wrote:
>>>>> On 2015-03-17 15:26, Thomas Schatzl wrote:
>>>>>> Hi Mikael,
>>>>
>>>> [...]
>>>
>>>
>>> Some last-minute comment if it is not still too late:
>>>
>>> - G1CollectedHeap::set_par_threads(uint t) can be removed. It only calls
>>> the inherited method anyway.
>>
>> Right, removed it.
>>
>> Final full webrev at
>> http://cr.openjdk.java.net/~mgerdin/8075210/full3/webrev/
>> I didn't create an incremental for the removal of
>> G1CollectedHeap::set_par_threads(uint t), I hope that's ok.
>>
>> You need to look at the sdiff to see the blobsCl alignment:
>> http://cr.openjdk.java.net/~mgerdin/8075210/full3/webrev/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp.sdiff.html
>
> It seems that in the call to scan_remembered_set() the parameters are
> not aligned either. *duck*

I'll fix it before I push.

>
> Looks good. :)

Thanks for the review.

/m

>
> Thanks a lot,
> Thomas
>
>