RFR: JDK-8076073 - shared: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files

Bengt Rutisson bengt.rutisson at oracle.com
Fri Mar 27 13:49:12 UTC 2015


On 2015-03-27 14:39, Stefan Karlsson wrote:
> On 27/03/15 14:29, David Lindholm wrote:
>> Hi,
>>
>> After some discussions with StefanK I have updated this webrev. I 
>> have reverted the changes to files not "owned" by us, and I have made 
>> some minor changes to heapInspection.cpp
>>
>> New webrev: http://cr.openjdk.java.net/~david/JDK-8076073/webrev.01/
>
> Looks good.

Looks good to me too.

Bengt

>
> StefanK
>
>>
>>
>> Thanks,
>> David
>>
>> On 2015-03-27 10:23, David Lindholm wrote:
>>> Hi,
>>>
>>> Please review this fix that removes the macro 
>>> PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC in gc files and fixes the gcc 
>>> warnings for the format strings. Some files had this macro even 
>>> though there were no warnings in them.
>>>
>>> This patch deals with all the source files in 
>>> vm/gc_implementation/shared/ and vm/memory/ that had this macro.
>>>
>>> Webrev: http://cr.openjdk.java.net/~david/JDK-8076073/webrev.00/
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8076073
>>>
>>> Testing done: Passed JPRT
>>>
>>>
>>> Thanks,
>>> David
>>
>




More information about the hotspot-gc-dev mailing list