RFR (S): JDK-8076225: Move the thread claim parity from SharedHeap to Thread

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Mon Mar 30 13:40:49 UTC 2015


Looks good.

I assume you count yourself as a Reviewer(?)
/Jesper


Bengt Rutisson skrev den 30/3/15 13:27:
>
> Hi everyone,
>
> This patch was contributed by Mikael Gerdin, I'm mostly just shepherding this
> patch in to the repo.
>
> http://cr.openjdk.java.net/~brutisso/8076225/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8076225
>
>  From the bug report:
>
> The thread claim parity is used to parallelize the scanning of root in the
> JavaThreads. This was placed in SharedHeap, but used by the Thread class
> (Threads::possibly_parallel_oops_do()). Moving this claiming state into the
> Thread class will collect the state information and the usage in one place. It
> will also anther step towards eventually being able to remove SharedHeap.
>
>
> Apart from just moving the claiming state, Mikael also added an assert that
> verifies that all Java threads have the correct parity after a GC. This is to
> quickly find out if anybody forgets to handle the Java threads during root
> processing at some point.
>
> Thanks,
> Bengt
>



More information about the hotspot-gc-dev mailing list