Request for Review (s) - 8133023: ParallelGCThreads is not calculated correctly
Thomas Schatzl
thomas.schatzl at oracle.com
Tue Nov 17 15:11:02 UTC 2015
Hi,
On Thu, 2015-11-12 at 13:31 -0800, Jon Masamitsu wrote:
> GC calls VM_Version::calc_parallel_worker_threads() to determine
> the number of GC threads to create. On Sparc it checks for newer
> Niagara hardware to decide the proper scaling of the GC threads with
> the hardware threads. calc_parallel_worker_threads() was being called
> before enough information was gathered to determine the Sparc
> hardware.
>
> Moved the gathering of information needed to earlier in the JVM
> initialization.
>
> http://cr.openjdk.java.net/~jmasa/8133023/webrev.00/
>
> https://bugs.openjdk.java.net/browse/JDK-8133023
>
one comment: in vm_version-sparc.hpp, the assert should probably use
VM_Version::unknown_m instead of hardcoded zero.
No need to look at it again.
Looks good.
Thomas
More information about the hotspot-gc-dev
mailing list