RFR (S) 8016752: Test case for 8005857/8016740 (assert in GC_locker from PSOldGen::expand with -XX:+PrintGCDetails and Verbose)

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Thu Nov 26 10:02:15 UTC 2015


Hi Thomas,



On 23.11.2015 14:22, Thomas Schatzl wrote:
> Hi,
>
> On Fri, 2015-11-20 at 14:16 +0300, Dmitry Fazunenko wrote:
>> Hi Thomas,
>>
>> Thanks a lot for looking at the fix.  I totally agree with you: CR
>> should be well descriptive. Fixed.
>>
>> A question: This test is for Parallel only, because it's a regression
>> test for a problem in Parallel.
>> It could be easily made applicable for all collectors to check that
>> PrintGCDetails + Verbose doesn't crash when OOM happens.
>> What is your opinion, does it make any sense or that case is very unlikely?
>    I think this is a rather unlikely failure case. There are imo a lot of
> other tests more useful to spend available time on. But that's just imo.

I agree.
Thanks for the review!

-- Dima



>
> Thanks
>    Thomas
>
>




More information about the hotspot-gc-dev mailing list