RFR(S): 8139434: Unify GenRemSet and CardTableRS

David Lindholm david.lindholm at oracle.com
Tue Oct 13 09:14:24 UTC 2015


Jesper,

Thanks for looking at this. I fixed your comments and put up a new webrev:

http://cr.openjdk.java.net/~david/JDK-8139434/webrev.01/


Thanks,
David

On 2015-10-12 22:48, Jesper Wilhelmsson wrote:
> Looks good in general.
>
> * In several files you have removed the include of genRemSet.hpp but 
> only i one place you add the include of cardTableRS.hpp. I think all 
> source files that uses CardTableRS should include cardTableRS.hpp
>
> * Minor indentation error at the end of the line in vmStructs.cpp
>
> Thanks,
> /Jesper
>
>
> Den 12/10/15 kl. 15:33, skrev David Lindholm:
>> Hi,
>>
>> Please review this patch that unifies GenRemSet and CardTableRS, since
>> CardTableRS is the only class that implements GenRemSet.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8139434
>> Webrev: http://cr.openjdk.java.net/~david/JDK-8139434/webrev.00/
>>
>> Testing: Passed JPRT
>>
>>
>> Thanks,
>> David




More information about the hotspot-gc-dev mailing list