RFR: JDK-8139772 - Cleanups in Generation related code

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Mon Oct 19 12:49:39 UTC 2015


Thanks for the reviews Tom and Mikael!

I moved the declaration down as suggested and changed "enquiries" to 
"inquiries". Is this British English vs American English? Both spellings are 
correct according to Google.
/Jesper

Den 19/10/15 kl. 09:33, skrev Mikael Gerdin:
> Jesper,
>
> looks good to me modulo Tom's comments.
> /Mikael
>
> On 2015-10-16 20:02, Tom Benson wrote:
>> Hi Jesper,
>> This looks good to me.  Only a minor comment that perhaps the declaration of
>> initial_size() in generation.hpp could be moved down to be with the other
>> "Space enquiries".    (You could correct the spelling of "enquiries" while you
>> were there. 8^) )
>> Tom
>>
>> On 10/16/2015 12:39 PM, Jesper Wilhelmsson wrote:
>>> Hi,
>>>
>>> Please review this cleanup of the Generation related code.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8139772
>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8139772/webrev.00/
>>>
>>> Thanks,
>>> /Jesper
>>
>



More information about the hotspot-gc-dev mailing list