RFR: 8140393: Move WorkerDataArray to its own file

Erik Helin erik.helin at oracle.com
Wed Oct 28 13:16:25 UTC 2015


On 2015-10-28, Mikael Gerdin wrote:
> Hi Erik,
> 
> On 2015-10-27 16:07, Erik Helin wrote:
> >All,
> >
> >I've split the patch into two patches in order to ease the reviewing (I
> >still indend to push this as one change). The first patch changes the
> >current implementation of the class WorkerDataArray, particularly
> >removing the caching mechanism. The second patch just shuffles code
> >around into new files (and also adds some basic tests).
> >
> >Webrevs:
> >- Step 1: http://cr.openjdk.java.net/~ehelin/8140393/webrev.01-1/
> >- Step 2: http://cr.openjdk.java.net/~ehelin/8140393/webrev.01-2/
> 
> Thanks for splitting up the change, it makes reviews much easier.
> The change looks good to me.

Thanks! I've been asked to push this as two changes instead of (which I
don't mind doing). Are you ok with that? You will just become reviewer
of both patches.

Thanks,
Erik

> /Mikael
> 
> >
> >Thanks,
> >Erik
> >
> >On 2015-10-26, Erik Helin wrote:
> >>Hi all,
> >>
> >>this patch moves the class WorkerDataArray into its own file. While
> >>moving to the code, I also refurbished it a bit. WorkerDataArray used
> >>to cache the results for calls to max(), min(), sum() etc because it
> >>might be expensive too loop over the array. However, the array we are
> >>iterating over will at most be as big as the number of GC threads (it is
> >>very rare to use more than 1000 GC threads). Performance runs shows no
> >>regressions at all, so I prefer to go with the simpler code.
> >>
> >>Enhancement:
> >>https://bugs.openjdk.java.net/browse/JDK-8140393
> >>
> >>Webrev:
> >>http://cr.openjdk.java.net/~ehelin/8140393/webrev.00/
> >>
> >>Testing:
> >>- JPRT
> >>- Perf Aurora for performance regressions
> >>
> >>Thanks,
> >>Erik
> 



More information about the hotspot-gc-dev mailing list