RFR: JDK-8141049: Remove CARD_REPEAT_HISTO from the G1 code

Thomas Schatzl thomas.schatzl at oracle.com
Fri Oct 30 12:33:15 UTC 2015


Hi,

On Fri, 2015-10-30 at 13:05 +0100, Bengt Rutisson wrote:
> Hi everyone,
> 
> Yet another define that guards dead debugging code.
> 
> http://cr.openjdk.java.net/~brutisso/8141049/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8141049
> 
> The CARD_REPEAT_HISTO define is used in the code to log more detailed 
> information about the marking cycle. Since this is a define that 
> requires re-compilation to have any effect the code is not used by 
> normal builds.
> 
> Thus, this is to be considered debug code. As such it should be removed 
> from the normal code base and included back if it is needed for a debug 
> session.

  looks good.

Thomas






More information about the hotspot-gc-dev mailing list