RFR: 8146989: Introduce per-worker preserved mark stacks in ParNew

[Srinivas Ramakrishna]

(as Thomas may have remarked earlier, some of the modified files need
copyright date updated to 2016. Not sure if that is done nowadays at the
time of making a modification to a file, or in a blanket sweep by release
engineering at some future time -- as used to be the case in the hoary past
at least. :)

On Wed, Feb 17, 2016 at 11:18 AM, Srinivas Ramakrishna <ysr1729 at gmail.com>
wrote:

>
> Reviewed! The changes look good to me. Looking forward to the related
> changes for the other collectors soon.
>
> thanks,
> -- ramki (openjdk: ysr)
>
>
> On Wed, Feb 17, 2016 at 10:27 AM, Thomas Schatzl <
> thomas.schatzl at oracle.com> wrote:
>
>> Hi Tony,
>>
>>   sorry for the late reply.
>>
>> Change looks good to me. I will sponsor it after waiting a few more days
>> to push for other persons to have a look.
>>
>> Thanks,
>>   Thomas
>>
>> On Mo, 2016-02-08 at 16:16 -0500, Tony Printezis wrote:
>> > Thomas,
>> >
>> >
>> > Latest changes:
>> >
>> >
>> > http://cr.openjdk.java.net/~tonyp/8146989/webrev.4/
>> >
>> >
>> > BTW, I moved do_object() to the .cpp file instead of the .inline.hpp
>> > file (it’s virtual, so it won’t be inlined anyway).
>> >
>> >
>> > Tony
>> >
>> > On February 8, 2016 at 2:56:56 PM, Tony Printezis
>> > (tprintezis at twitter.com) wrote:
>> >
>> > >
>> > > Thanks Thomas, I’ll fix those and post a new webrev shortly...
>> > >
>> > >
>> > > Tony
>> > >
>> > > On February 8, 2016 at 10:56:56 AM, Thomas Schatzl
>> > > (thomas.schatzl at oracle.com) wrote:
>> > >
>> > > > Hi,
>> > > >
>> > > > On Mon, 2016-02-08 at 09:49 -0500, Tony Printezis wrote:
>> > > > > Thanks Thomas. Also, if you could do a JPRT run I’d very much
>> > > > > appreciate it.
>> > > >
>> > > > that is of course part of it.
>> > > >
>> > > > It found two issues:
>> > > > - RemoveForwardedPointerClosure::do_object() needs to be moved to
>> > > > the
>> > > > preservedMarks.inline.hpp as it uses oopDesc::is_forwarded() and
>> > > > init(). Then also oop.inline.hpp needs to be included there.
>> > > >
>> > > > - PreservedMarksSet::reclaim() needs to call
>> > > > ~Padded<Preservedmarks>(), not just ~PreservedMarks.
>> > > >
>> > > > >
>> > > > > FWIW, I tested it with doing many runs of all the usual test
>> > > > suites
>> > > > > with -XX:+PromotionFailureALot -XX:PromotionFailureALotCount=150
>> > > > > -XX:PromotionFailureALotInterval=2 and this cause a bunch of
>> > > > > promotion failures. I didn’t see any issues.
>> > > > >
>> > > > > I also have the ParallelScavenge changes done (using the
>> > > > abstractions
>> > > > > introduced here). I’ll open those for code review when this is
>> > > > done.
>> > > >
>> > > > Thanks,
>> > > > Thomas
>> > > >
>> > > >
>> > > >
>> > > -----
>> > >
>> > >
>> > > Tony Printezis | JVM/GC Engineer / VM Team | Twitter
>> > >
>> > >
>> > > @TonyPrintezis
>> > > tprintezis at twitter.com
>> > >
>> > >
>> > -----
>> >
>> >
>> > Tony Printezis | JVM/GC Engineer / VM Team | Twitter
>> >
>> >
>> > @TonyPrintezis
>> > tprintezis at twitter.com
>> >
>> >
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20160217/c6be5198/attachment.htm>