RFR (M): 8146987: Improve Parallel GC Full GC by caching results of live_words_in_range() [Was: Re: [PATCH] enhancement to ParallelScavenge Full GC]

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jan 14 21:25:02 UTC 2016


Hi Jon,

On Thu, 2016-01-14 at 13:04 -0800, Jon Masamitsu wrote:
> http://cr.openjdk.java.net/~tschatzl/8146987/webrev.1/src/share/vm/gc
> /parallel/psCompactionManager.hpp.frames.html
> 
> Please initialize these in the constructor
> 
> 112 HeapWord* _last_query_beg;
> 113 oop _last_query_obj;
> 114 size_t _last_query_ret;

They will be initialized in PSParallelCompact::pre_compact(), but I
will add a call to reset_... in the constructor.

> 
> http://cr.openjdk.java.net/~tschatzl/8146987/webrev.1/src/share/vm/oo
> ps/oop.hpp.udiff.html
> 
> Any reason to use "pc" as the parameter name here and
> not "cm" as is used elsewhere?
> 
> - void pc_update_contents();
> + void pc_update_contents(ParCompactionManager* pc);

Will fix.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list