RFR: 8158412: [TESTBUG] TestIHOPErgo and TestStressG1Humongous should not be executed when JFR is enabled

[Dmitry Fazunenko]

Looks good.

Thanks,
Dima

On 14.06.2016 21:50, Michail Chernov wrote:
> HI Thomas, Dima
>
> Thanks for your comments.
>
> Properties expression were changed to "!vm.flightRecorder".
>
> Updated webrev (hotspot) : 
> http://cr.openjdk.java.net/~mchernov/8158412/webrev.hotspot.01/
>
> Michail
>
> On 06/14/2016 04:33 PM, Thomas Schatzl wrote:
>> Hi,
>>
>> On Tue, 2016-06-14 at 16:23 +0300, Dmitry Fazunenko wrote:
>>> Michail,
>>>
>>> On 14.06.2016 15:22, Thomas Schatzl wrote:
>>>> Hi Mikael,
>>>>
>>>> On Wed, 2016-06-08 at 16:49 +0300, 8038818: Test Chernov wrote:
>>>>> Hi,
>>>>>
>>>>> Could I have a reviews for this small fix? The fix adds new
>>>>> custom JTreg setting for @requires tag - vm.FlightRecorder. New
>>>>> setting is used in all updated tests. Tests will be exclude if
>>>>> JFR is enabled.
>>>>>
>>>>> https://bugs.openjdk.java.net/browse/JDK-8158412
>>>>> http://cr.openjdk.java.net/~mchernov/8158412/webrev.root.00/
>>>>> http://cr.openjdk.java.net/~mchernov/8158412/webrev.hotspot.00/
>>>>>
>>>>> Testing - RBT.
>>>>     seems okay, however the syntax to use vm.FlightRecorder seems
>>>> awkward, i.e.
>>>>
>>>> "vm.FlighRecorder != true"
>>>>
>>>> Isn't there a way to make it something more common like
>>>> !vm.FlightRecorder?
>>>>
>>>> Not insisting on this, just asking.
>>> Yes, there is no need to use vm.xxx != true anymore, for those
>>> properties which are set by our plugin (VMProps).
>>> All such properties will never be set to 'null', as it's possible for
>>> vm.opt.xxx, which are set by jtreg.
>>> So, using !vm.FlightRecored is safe.
>>    then I would prefer to use vm.FlightRecorder this way in the tests.
>>
>> Thanks,
>>    Thomas
>>
>>
>