Request for Review (xs) - 8024945: Remove check on minimum size of MetaspaceSiz
Jon Masamitsu
jon.masamitsu at oracle.com
Fri Jun 24 17:19:19 UTC 2016
Thanks Kim and Thomas for the previous reviews. Sorry for delay with the
latest updates.
The only change from the first round is update of the @bug (as Kim
indicated) and the copyright update.
The updated complete webrev is here
http://cr.openjdk.java.net/~jmasa/8024945/webrev.01/
The delta is
--- a/test/gc/metaspace/TestMetaspaceInitialization.java
+++ b/test/gc/metaspace/TestMetaspaceInitialization.java
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -24,7 +24,7 @@
import java.util.ArrayList;
/* @test TestMetaspaceInitialization
- * @bug 8042933
+ * @bug 8024945
* @summary Tests to initialize metaspace with a very low MetaspaceSize
Thanks.
Jon
On 6/13/2016 3:43 PM, Jon Masamitsu wrote:
>
>
> On 06/13/2016 03:29 PM, Kim Barrett wrote:
>>> On Jun 13, 2016, at 5:56 PM, Jon Masamitsu
>>> <jon.masamitsu at oracle.com> wrote:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8024945
>>>
>>> Previous to this change the smallest MetaspaceSize value allowed
>>> was 256k. There is not reason for the restriction so this change
>>> removes it. A very small MetaspaceSize (even 0) does not cause
>>> a problem because during initialization a GC is not triggered unless
>>> the Metaspace needed grows beyond MaxMetaspaceSize.
>>>
>>> http://cr.openjdk.java.net/~jmasa/8024945/webrev.00/
>>>
>>> Tested with -XX:MetaspaceSize=0. General testing with gc_test_suite.
>> Looks good.
>
> Thanks.
>
>> ------------------------------------------------------------------------------
>>
>> test/gc/metaspace/TestMetaspaceInitialization.java
>> 27 * @bug 8042933
>>
>> Should this be updated to also mention 8024945?
>
> Ah, yes.
>
> Fixed.
>
> Jon
>>
>> ------------------------------------------------------------------------------
>>
>>
>
More information about the hotspot-gc-dev
mailing list