RFR: JDK-8151196 Several tests fail due to test library not found

Christian Tornqvist christian.tornqvist at oracle.com
Wed Mar 9 10:29:50 UTC 2016


Hi Staffan,

Looks good, thanks for fixing this.

Thanks,
Christian

-----Original Message-----
From: serviceability-dev
[mailto:serviceability-dev-bounces at openjdk.java.net] On Behalf Of Staffan
Larsen
Sent: Wednesday, March 9, 2016 5:03 AM
To: Bengt Rutisson <bengt.rutisson at oracle.com>
Cc: serviceability-dev at openjdk.java.net; hotspot-gc-dev at openjdk.java.net
Subject: Re: RFR: JDK-8151196 Several tests fail due to test library not
found

Good catch. Incremental change:

diff --git a/test/gc/g1/plab/TestPLABResize.java
b/test/gc/g1/plab/TestPLABResize.java
--- a/test/gc/g1/plab/TestPLABResize.java
+++ b/test/gc/g1/plab/TestPLABResize.java
@@ -27,7 +27,7 @@
  * @summary Test for PLAB resizing
  * @requires vm.gc=="G1" | vm.gc=="null"
  * @requires vm.opt.FlightRecorder != true
- * @library /testlibrary /../../test/lib /
+ * @library /testlibrary /test/lib /
  * @modules java.management
  * @build ClassFileInstaller
  *        sun.hotspot.WhiteBox

> On 9 mars 2016, at 10:54, Bengt Rutisson <bengt.rutisson at oracle.com>
wrote:
> 
> 
> Hi Staffan,
> 
> Changes look good.
> 
> However it looks like this test has the same issue, right?
>
http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/file/59d3a69564dc/test/gc/g1
/plab/TestPLABResize.java
> 
> It is currently ignored, but we should probably fix it too...
> 
> Thanks,
> Bengt
> 
> On 2016-03-09 10:47, Staffan Larsen wrote:
>> Please review this small fix to some tests with the wrong paths in
them. Tested locally with jtreg 4.1 b12 and b13.
>> 
>> Thanks,
>> /Staffan
>> 
>> 
>> $ hg diff
>> diff --git a/test/gc/g1/plab/TestPLABPromotion.java
b/test/gc/g1/plab/TestPLABPromotion.java
>> --- a/test/gc/g1/plab/TestPLABPromotion.java
>> +++ b/test/gc/g1/plab/TestPLABPromotion.java
>> @@ -27,7 +27,7 @@
>>   * @summary Test PLAB promotion
>>   * @requires vm.gc=="G1" | vm.gc=="null"
>>   * @requires vm.opt.FlightRecorder != true
>> - * @library /testlibrary /../../test/lib /
>> + * @library /testlibrary /test/lib /
>>   * @modules java.management
>>   * @build ClassFileInstaller
>>   *        sun.hotspot.WhiteBox
>> diff --git a/test/serviceability/dcmd/gc/HeapDumpAllTest.java
b/test/serviceability/dcmd/gc/HeapDumpAllTest.java
>> --- a/test/serviceability/dcmd/gc/HeapDumpAllTest.java
>> +++ b/test/serviceability/dcmd/gc/HeapDumpAllTest.java
>> @@ -35,7 +35,7 @@
>>   * @build jdk.test.lib.hprof.*
>>   * @build jdk.test.lib.hprof.model.*
>>   * @build jdk.test.lib.hprof.parser.*
>> - * @build jdk.test.lib.hprof.utils.*
>> + * @build jdk.test.lib.hprof.util.*
>>   * @build HeapDumpTest
>>   * @run testng HeapDumpAllTest
>>   */
>> diff --git a/test/serviceability/dcmd/gc/HeapDumpTest.java
b/test/serviceability/dcmd/gc/HeapDumpTest.java
>> --- a/test/serviceability/dcmd/gc/HeapDumpTest.java
>> +++ b/test/serviceability/dcmd/gc/HeapDumpTest.java
>> @@ -51,7 +51,7 @@
>>   * @build jdk.test.lib.hprof.*
>>   * @build jdk.test.lib.hprof.model.*
>>   * @build jdk.test.lib.hprof.parser.*
>> - * @build jdk.test.lib.hprof.utils.*
>> + * @build jdk.test.lib.hprof.util.*
>>   * @run testng HeapDumpTest
>>   */
>>  public class HeapDumpTest {
> 





More information about the hotspot-gc-dev mailing list