RFR (3rd): 8140257: Add support for "gc service threads" to ConcurrentGCThread
Kim Barrett
kim.barrett at oracle.com
Fri Mar 11 20:05:42 UTC 2016
> On Mar 10, 2016, at 11:51 AM, Derek White <derek.white at oracle.com> wrote:
>
> Thanks Per,
>
> I made the change and spun a new webrev for the curious, and ran through jprt.
>
> Any comments Kim?
>
> *Bug*: https://bugs.openjdk.java.net/browse/JDK-8140257
> *Webrev*: http://cr.openjdk.java.net/~drwhite/8140257/webrev.05/
> *Incremental webrev:*
> http://cr.openjdk.java.net/~drwhite/8140257/webrev.v04.v05/
>
> -
Looks good.
One minor thing below. I don’t need a new webrev if that change is made.
------------------------------------------------------------------------------
src/share/vm/gc/shared/concurrentGCThread.hpp
43 void initialize_in_thread();
46 void wait_for_universe_init();
50 void terminate();
Do these still need to be protected? I suspect they could be private.
------------------------------------------------------------------------------
More information about the hotspot-gc-dev
mailing list