RFR(S): 8173013: JVMTI tagged object access needs G1 pre-barrier

Thomas Schatzl thomas.schatzl at oracle.com
Mon Feb 6 09:22:44 UTC 2017


Hi,

On Mon, 2017-02-06 at 01:17 -0500, Kim Barrett wrote:
> > 
> > On Feb 6, 2017, at 1:10 AM, sangheon <sangheon.kim at oracle.com>
> > wrote:
> > 
> > Hi Kim and Thomas,
> > 
> > Here's webrev.2 with Thomas' comment version.
> > http://cr.openjdk.java.net/~sangheki/8173013/webrev.2
> > 
> > --------------------
> > 1538 #if INCLUDE_ALL_GCS
> > 1539         if (UseG1GC) {
> > 1540           // The reference in this tag map could be the only
> > (implicitly weak)
> > 1541           // reference to that object. If we hand it out, we
> > need to keep it live wrt
> > 1542           // SATB marking similar to other j.l.ref.Reference
> > referents.
> > 1543           G1SATBCardTableModRefBS::enqueue(o);
> > 1544         }
> > 1545 #endif
> > ——————————
> Looks good.

  looks good. Ship it.

Thomas


More information about the hotspot-gc-dev mailing list