RFR (7xS): 8178148: Log more detailed information about scan rs phase

sangheon sangheon.kim at oracle.com
Tue Jun 13 21:29:06 UTC 2017


Hi Thomas,

On 06/13/2017 05:21 AM, Erik Helin wrote:
> On 06/12/2017 01:34 PM, Thomas Schatzl wrote:
>> Hi all,
>>
>>   sorry for another round of reviews: Erik asked me to add a gtest test
>> for the linked subitems, both for the (existing) set() and (new) add()
>> methods.
>>
>> Webrev: http://cr.openjdk.java.net/~tschatzl/8178148/webrev.2_to_3/ (di
>> ff): http://cr.openjdk.java.net/~tschatzl/8178148/webrev.3/ (full)
>>
>> Testing:
>> local testing, jprt
>
> Looks good, Reviewed.
Looks good to me too.

Thanks,
Sangheon


>
> Thanks,
> Erik
>
>> Thanks,
>>   Thomas
>>
>> On Tue, 2017-05-23 at 12:15 -0700, sangheon wrote:
>>> Hi Thomas,
>>>
>>> On 05/23/2017 05:50 AM, Thomas Schatzl wrote:
>>>>
>>>> Hi all,
>>>>
>>>>    unfortunately, for support of some code there is need for one
>>>> more
>>>> public method in the g1gcphasetimes class.
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~tschatzl/8178148/webrev.1_to_2/ (diff)
>>>> http://cr.openjdk.java.net/~tschatzl/8178148/webrev.2/ (full)
>>> Webrev.2 still looks good to me.
>>>
>>> Thanks,
>>> Sangheon
>>>
>>>
>>>>
>>>>
>>>> Sorry for the issue.
>>>>
>>>> Thanks,
>>>>    Thomas
>>>>




More information about the hotspot-gc-dev mailing list