[PATCH] JDK-8176571: Fine bitmaps should be allocated as belonging to mtGC

Milan Mimica Milan.Mimica at infobip.com
Wed Jun 14 13:59:14 UTC 2017


Hi


Milan Mimica, Senior Software Engineer / Division Lead
> From: Thomas Schatzl <thomas.schatzl at oracle.com>
> Sent: Wednesday, June 14, 2017 14:58
> To: Milan Mimica; hotspot-gc-dev at openjdk.java.net
> Subject: Re: [PATCH] JDK-8176571: Fine bitmaps should be allocated as belonging to mtGC
>
>> Oh, I 've developed it against jdk10/jdk10. Care to explain a bit the
>> difference? Attached are patches against jdk10/hs.
>
> jdk10/hs is the current development tree where development happens and
> new changes pushed into. hs10/hs10 is the tree where public builds are
> made from. Changes are regularly (at least in the typical case) merged
> to jdk10/jdk10 after some additional regression testing.

I see. Thanks.


> I created https://bugs.openjdk.java.net/browse/JDK-8182169 for the
> ArrayAllocator refactoring as I could not find an existing issue.
>
> I uploaded a webrev of that change to
> http://cr.openjdk.java.net/~tschatzl/8182169/webrev/
>
> Looks good to me.
>
> I also uploaded a webrev for JDK-8176571 based on the above to
> http://cr.openjdk.java.net/~tschatzl/8176571/webrev
>
> Looks good to me too, but is there a reason to not use default parameters for the CHeapBitmap constructors?

I'd rather somehow make the argument mandatory, to force people to choose a memory category.



More information about the hotspot-gc-dev mailing list