RFR (S) 8069343: Improve gc/g1/TestHumongousCodeCacheRoots.java to use jtreg @requires

Thomas Schatzl thomas.schatzl at oracle.com
Thu Aug 2 10:29:56 UTC 2018


Hi JC,

  pushed. I removed one more "Contributed-by" line as the user has been
set to you properly already.

Thanks,
  Thomas

On Wed, 2018-08-01 at 09:30 -0700, JC Beyler wrote:
> Hi Thomas,
> 
> Thanks for the reviews and yes I am looking for a sponsor for all so
> if you can push them that would be awesome.
> 
> Here are the links to the updated ones for ease on your side (I
> hope):
> http://cr.openjdk.java.net/~jcbeyler/8208249/webrev.01/
> http://cr.openjdk.java.net/~jcbeyler/8208246/webrev.01/
> http://cr.openjdk.java.net/~jcbeyler/8069343/webrev.02/
> 
> The 8169004 one, I have put you as a reviewer, you changed the title
> and description (thanks, being at JVM LS, I cannot log in to JBS
> during the day due to wifi security :-)):
> http://cr.openjdk.java.net/~jcbeyler/8169004/webrev.02/
> 
> (I also removed my contributed-by, Igor told me it was redundant
> since I'm the author).
> 
> Thanks for all your help!
> Jc
> 
> 
> 
> 
> On Wed, Aug 1, 2018 at 7:52 AM Thomas Schatzl <thomas.schatzl at oracle.
> com> wrote:
> > On Wed, 2018-08-01 at 16:50 +0200, Thomas Schatzl wrote:
> > > Hi,
> > > 
> > > On Tue, 2018-07-31 at 09:50 -0700, JC Beyler wrote:
> > > > Hi all,
> > > > 
> > > > I cleaned up the TestHumongousCodeCacheRoots to no longer try
> > to do
> > > > client and then server test runs.
> > > > 
> > > > Let me know what you think:
> > > > 
> > > > Webrev: http://cr.openjdk.java.net/~jcbeyler/8069343/webrev.01/
> > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8069343
> > > > 
> > > 
> > >   looks good.
> > > 
> > > If you are still looking for a sponsor for this (JDK-8069343),
> > JDK-
> > > 8208249, and JDK-8208246 I can push all three (tomorrow).
> > 
> >   ... and JDK-8169004?
> > 
> > Thanks,
> >   Thomas
> > 
> 
> 




More information about the hotspot-gc-dev mailing list