RFR (M): 8209061: Move G1 serviceability functionality to G1MonitoringSupport

Hohensee, Paul hohensee at amazon.com
Fri Aug 10 16:51:53 UTC 2018


Hi Thomas,

LGTM, except,

g1MonitoringSupport.hpp:
Is there a way to avoid making G1MonitoringScope be a friend class to G1MonitoringSupport?

Thanks,

Paul

On 8/8/18, 3:55 AM, "hotspot-gc-dev on behalf of Thomas Schatzl" <hotspot-gc-dev-bounces at openjdk.java.net on behalf of thomas.schatzl at oracle.com> wrote:

    Hi all,
    
      can I have reviews for this cleanup that moves all serviceability
    functionality into the G1MonitoringSupport class.
    
    CR:
    https://bugs.openjdk.java.net/browse/JDK-8209061
    Webrev:
    http://cr.openjdk.java.net/~tschatzl/8209061/webrev/
    Testing:
    hs-tier1-4, jdk-tier1-3
    
    Depends on JDK-8208498 also out for review.
    
    Thanks,
      Thomas
    
    



More information about the hotspot-gc-dev mailing list