RFR: 8209345: Merge SATBMarkQueueFilter into SATBMarkQueueSet

Aleksey Shipilev shade at redhat.com
Mon Aug 13 08:03:44 UTC 2018


On 08/13/2018 04:08 AM, Kim Barrett wrote:
> Please review this change that eliminates SATBMarkQueueFilter in favor
> of an extension to SATBMarkQueueSet.  The QSet's _filter member and
> filter function that invokes it are replaced by a virtual function on
> the QSet.  G1SATBMarkQueueSet provides an implementation copied from
> the former G1SATBMarkQueueFilter.
> 
> Changed SATBMarkQueueSet's constructor and destructor from public to
> protected, since it's a base class.  Also made initialize protected,
> as it should only be called from derived classs.
> 
> This changeset is based on the in-review change for JDK-8209396.
> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2018-August/022868.html
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8209345
> 
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8209345/open.00/

Looks good.

-Aleksey


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180813/6e8c036c/signature.asc>


More information about the hotspot-gc-dev mailing list