RFR: 8209346: Refactor SATBMarkQueue filter configuration

[Aleksey Shipilev]

On 08/13/2018 04:12 AM, Kim Barrett wrote:
> Please review this change to how SATBMarkQueue determines whether a
> post-filtered buffer should be enqueued or continue to be used.
> 
> The qset's initialize function is now called with an enqueue threshold
> percentage; G1 uses G1SATBBufferEnqueuingThresholdPercentage.  This
> value is translated by initialize into a threshold index recorded in
> the qset.
> 
> The queue's should_enqueue_buffer now obtains that threshold index and
> compares it to the post-filter index to determine whether the buffer
> should be enqueued or continue to be used.
> 
> This changeset is based on the in-review changes for JDK-8209396 and
> JDK-8209345.
> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2018-August/022868.html
> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2018-August/022869.html
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8209346
> 
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8209346/open.00/

Looks good.

I think you can use MAX2<T>(...) here:

 124   _buffer_enqueue_threshold = MAX2(size - enqueue_qty, (size_t)1);

...

 124   _buffer_enqueue_threshold = MAX2<size_t>(size - enqueue_qty, 1);

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20180813/df4546f1/signature.asc>