RFR: 8209346: Refactor SATBMarkQueue filter configuration

Roman Kennke rkennke at redhat.com
Tue Aug 14 09:06:01 UTC 2018


>> On Aug 13, 2018, at 6:40 AM, Roman Kennke <rkennke at redhat.com> wrote:
>>
>> Oops no wait. This was intended to go to another thread.
>>
>> Doesn't this require a change in g1_globals.hpp for the changed global?
>>
>> While changing the global anyway, could we make it non-G1 too?
> 
> I didn’t change the global at all.

Ah right. I wasn't aware that G1SATBBufferEnqueueingThresholdPercent did
already exist. However, now G1SATBProcessCompletedThreshold is unused,
is it?

> Making it no longer G1-specific (e.g. renaming it)
> requires going through the CSR process.  It’s also not necessary for the purpose of
> making the SATB code GC-agnostic and moving it to shared; the Shenandoah qset
> initialization can pass in it’s preferred value.

Sure.

> I changed the internal handling of the configuration value, translating it from a
> percentage to an index for direct comparison with the post-filtered buffer index,
> rather than the old code that used that index to compute percent full and compared
> that to the CLA option.  But the form of the configuration value (a percent full
> threshold) hasn’t changed.

I see. The change looks good to me.

Thank you!
Roman




More information about the hotspot-gc-dev mailing list