RFR (M): 8208498: Put archive regions into a first-class HeapRegionSet

Thomas Schatzl thomas.schatzl at oracle.com
Wed Aug 22 08:28:06 UTC 2018


Hi,

On Tue, 2018-08-21 at 15:40 -0700, sangheon.kim at oracle.com wrote:
> Hi Thomas,
> 
> On 8/20/18 7:58 AM, Thomas Schatzl wrote:
> > Hi,
> >
> > On Tue, 2018-08-14 at 17:24 +0000, Hohensee, Paul wrote:
> > > 
> > > [...]
> > > Anyway, that's complex enough to be its own RFE, so I'd be happy
> > > if you just put the For* constants in an enum. :)
> > 
> > I agree. I have some patches for cleaning this up already,
> > effectively removing this new enum. However it just adds some noise
> > for this particular change.
> > 
> > New webrevs at
> > http://cr.openjdk.java.net/~tschatzl/8208498/webrev.0_to_1/ (diff)
> > http://cr.openjdk.java.net/~tschatzl/8208498/webrev.1/ (full)
> 
> Looks good to me too.
> 
> Thanks,
> Sangheon
> 

  thanks for your review.

Thomas



More information about the hotspot-gc-dev mailing list