RFR (S): [TESTBUG] Test for JDK-8180048

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jan 11 10:01:55 UTC 2018


Hi Erik and Kim,

On Wed, 2018-01-10 at 17:44 +0100, Erik Österlund wrote:
> Hi Thomas,
> 
> Looks good.
> Note though that...
> 
>    82         Asserts.assertLT(reserved, ReservedThreshold,
> "Reserved 
> memory size is " + reserved + "KB which is higher than " + 
> ReservedThreshold + "KB indicating a memory leak");
> 
> ...I guess it should say "greater than or equal to" instead of
> "higher than", but I'm not sure if I really care all that much.
> 
> Also, the copyright years might need some tweaking.

I will fix both before pushing.

> 
> I don't need another webrev.

Thanks a lot for your reviews.

Thomas




More information about the hotspot-gc-dev mailing list