RFR: 8210237: gc/stress/TestStressIHOPMultiThread.java fails with 'Unexpected exit from test [exit code: 1]' in CDS mode

[Jiangli Zhou]

Hi Gerard,


On 9/14/18 2:08 PM, Gerard Ziemski wrote:
> hi Jiangli,
>
> Thank you for the clarification.
>
> I wonder if we have some agreed upon exit status that tells Mach5 framework (and others) that a test finished trivially, so it can be marked as “skipped”, “not run”, or “trivially run”? Seems we have a few tests that may not get to finish their run due to various reasons.
That's a good question. From what I understand, for a test that's not 
run/skipped under various conditions, a SkippedException can be thrown 
by the test. The harness marks the execution as skipped instead of 
passed normally. For TestStressIHOPMultiThread.java (with the fix), if 
OOM occurs in one thread, other thread continues until specified timeout 
reaches. It's not skipped, but probably could be considered as 
'trivially run' (less load). I did some searches but couldn't find a 
jtreg status corresponding to  'trivially run'. It sounds like a good 
idea to have this kind of fine grained status.

Thanks,
Jiangli
>
>
> cheers
>
>
>> On Sep 14, 2018, at 2:22 PM, Jiangli Zhou <jiangli.zhou at oracle.com> wrote:
>>
>> Hi Gerard,
>>
>> Thanks for the review! The assumption (can allocate up to the specified amount under low memory conditions) made by the test for all different configurations may not always be true and OutOfMemoryError could happen with some scenarios. The fix is to handle possible OutOfMemoryError in the test. The test is intended for IHOP testing with logging output. Adding the OOM handling does not seem to change the original intention. Sorry, I should have included more details in the RFR request.
>>
>> Thanks,
>>
>> Jiangli
>>
>>
>> On 9/14/18 11:55 AM, Gerard Ziemski wrote:
>>> hi Jiangli,
>>>
>>> So the fix here is to provide more diagnostic info, so that it can be later used to determine the real issue?
>>>
>>> Looks good if that’s the intend.
>>>
>>>
>>> cheers
>>>
>>>> On Sep 14, 2018, at 12:12 PM, Jiangli Zhou <jiangli.zhou at oracle.com> wrote:
>>>>
>>>> Please help review the fix for test TestStressIHOPMultiThread.java. This test has the similar issue as the one fixed earlier this week for JDK-8210193. Please see the bug report for detailed analysis.
>>>>
>>>>    webrev: http://cr.openjdk.java.net/~jiangli/8210237/webrev.00/
>>>>
>>>>    bug: https://bugs.openjdk.java.net/browse/JDK-8210237
>>>>
>>>> Tested with tier1 - tier3. Also tested with tier6 and tier7 with the default CDS archive patch.
>>>>
>>>> Thanks,
>>>>
>>>> Jiangli
>>>>