RFR: 8222182: ZGC: Use SoftMaxHeapSize to guide GC heuristics

[Stefan Karlsson]

Looks good.

StefanK

On 2019-04-17 10:44, Per Liden wrote:
> Did an off-line review with Stefan.
>
> Updated webrev:
> Diff: http://cr.openjdk.java.net/~pliden/8222182/webrev.1.diff
> Full: http://cr.openjdk.java.net/~pliden/8222182/webrev.1
>
> /Per
>
> On 04/11/2019 04:12 PM, Per Liden wrote:
>> Hi Thomas,
>>
>> On 04/11/2019 02:33 PM, Thomas Schatzl wrote:
>>> Hi Per,
>>>
>>> On Thu, 2019-04-11 at 13:50 +0200, Per Liden wrote:
>>>> Hi Thomas,
>>>>
>>>> Thank for looking at the patch. However, I'm afraid your comments
>>>> are based on incorrect assumptions, which makes them difficult to
>>>> address.
>>>> I'll try to clarify a few key points below. Hope that helps.
>>>
>>>    after looking at your comments, I got the source of my
>>> misunderstanding: I misread the change in zPageAllocator.cpp:112 to be
>>> a new version of ZPageAllocator::current_max_capacity(), but it changed
>>> to ZPageAllocator::soft_max_capacity().
>>>
>>> And the old contents of ZPageAllocator::current_max_capacity() has been
>>> inlined into ZPageAllocator::max_available().
>>>
>>> Sorry for the fuss. Looks good to me then.
>>
>> Great! No problem, thanks for reviewing.
>>
>>>
>>> Still I strongly recommend a release note :)
>>
>> That's a good idea and I will add one.
>>
>> cheers,
>> Per
>>
>>>
>>> Thanks,
>>>    Thomas
>>>
>>>