RFR(XS) 8228359: [TESTBUG] jdk.jfr.e.g.c.TestGCHeapConfigurationEventWith32BitOops.java does not expect MinHeapSize to be aligned to HeapAlignment

Langer, Christoph christoph.langer at sap.com
Wed Aug 7 14:29:49 UTC 2019


Hi Richard,

this little testfix looks good to me as well and I see it working perfectly in our JDK13 nightlies for the last days. If nobody on gc-dev has objections, I'll push it later today to JDK13.

Thanks
Christoph


> -----Original Message-----
> From: hotspot-gc-dev <hotspot-gc-dev-bounces at openjdk.java.net> On
> Behalf Of mikhailo.seledtsov at oracle.com
> Sent: Mittwoch, 24. Juli 2019 02:02
> To: Reingruber, Richard <richard.reingruber at sap.com>; hotspot-jfr-
> dev at openjdk.java.net; hotspot-gc-dev at openjdk.java.net
> Subject: Re: RFR(XS) 8228359: [TESTBUG]
> jdk.jfr.e.g.c.TestGCHeapConfigurationEventWith32BitOops.java does not
> expect MinHeapSize to be aligned to HeapAlignment
> 
> Looks good from my POV.
> 
> Adding hotspot-gc-dev at openjdk.java.net since this test concerns a GC
> event.
> 
> 
> Thank you,
> 
> Misha
> 
> On 7/18/19 6:56 AM, Reingruber, Richard wrote:
> > Hi,
> >
> > could I please get reviews for this small TESTBUG fix?
> >
> > Webrev:
> http://cr.openjdk.java.net/~rrich/webrevs/2019/8228359/webrev/
> > Bug:    https://bugs.openjdk.java.net/browse/JDK-8228359
> >
> > Since JDK-8223837 MinHeapSize is aligned to HeapAlignment and the test
> fails therefore on linuxppc, because there we have 64k pages and
> HeapAlignment is proportional to the page size.
> > The fix changes the test to expect the configured size of 100m to be aligned
> to HeapAlignment (32m on linuxppc).
> >
> > Tested on linuxppcle and on linuxx86_64.
> >
> > Thanks, Richard.


More information about the hotspot-gc-dev mailing list