RFR: 8224663: Parallel GC: Use WorkGang (5: ScavengeRootsTask)
Thomas Schatzl
thomas.schatzl at oracle.com
Fri Aug 9 03:56:06 UTC 2019
Hi Leo,
psScavenge.cpp:
364 // There are not old-to-young pointers if the old gen is empty.
s/not/no
No need for re-review for fixing the typo. Looks good otherwise.
Thomas
On 08.08.19 19:24, Leo Korinth wrote:
> Hi!
>
> Here is the latest fixup (fixup3) rebased on latest.
> http://cr.openjdk.java.net/~lkorinth/workgang/3/fixups/
>
> I will push it like this:
> http://cr.openjdk.java.net/~lkorinth/workgang/3/fixups_collapsed/
>
> All changes collapsed:
> http://cr.openjdk.java.net/~lkorinth/workgang/3/all_collapsed/
>
> I did fix JVMCI include order in:
> src/hotspot/share/gc/parallel/psParallelCompact.cpp
> but the include was rebased away in:
> src/hotspot/share/gc/parallel/psScavenge.cpp
>
> all 8 collapsed changes do compile and pass the :hotspot_gc with
> -XX:+UseParallelGC
>
> If you are okay with this I will run more testing on all changes, again
> checking performance and running slowdebugs etc.
>
> I also added StefanK as reviewer. He has suggested many improvements
> before the first public review.
>
> Are you okay with all the 8 commits?
>
> Thanks,
> Leo
More information about the hotspot-gc-dev
mailing list